WebUI: Add support for custom table pagination size #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvoborni
requested changes
Feb 17, 2017
install/ui/src/freeipa/facet.js
Outdated
|
|
||
| if (that.is_shown) that.refresh(); | ||
|
|
||
| that.set_expired_flag(); |
There was a problem hiding this comment.
Should the expiration flag be set first and then issuing the refresh?
install/ui/src/freeipa/field.js
Outdated
| * Javascript. | ||
| * | ||
| * @class | ||
| * @alternateClassName IPA.metadata_validator |
There was a problem hiding this comment.
alternate name is IPA.integer_validator
ipaserver/plugins/internal.py
Outdated
| @@ -250,6 +250,10 @@ class i18n_messages(Command): | |||
| "update": _("Update"), | |||
| "view": _("View"), | |||
| }, | |||
| "customization": { | |||
| "customization": _("Customization"), | |||
| "table_pagination": _("Table Pagination Size"), | |||
There was a problem hiding this comment.
What about using only "Pagination size". "Table" won't tell much to users. I.e. "what table?"
added 3 commits
March 8, 2017 13:11
Javascript integer validator checks whether value entered into field is number and is not higher than Number.MAX_SAFE_INTEGER constant. Part of: https://fedorahosted.org/freeipa/ticket/5742
Also added general setter and getter for attributes of config. Part of: https://fedorahosted.org/freeipa/ticket/5742
New customization button opens dialog with field for setting the number of lines in tables. After saving the new value there is new topic which starts refreshing current table facet (if shown) and set all other facets expired. Therefore all tables are immediately regenerated. https://fedorahosted.org/freeipa/ticket/5742
|
@pvoborni Thank you for review. Proposed changes fixed. |
pvoborni
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New customization button opens dialog with field for setting the number of lines
in tables. After saving the new value there is new topic which starts refreshing
current table facet (if shown) and set all other facets expired. Therefore all
tables are immediately regenerated.
https://fedorahosted.org/freeipa/ticket/5742