Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-pyasn1-modules into dependencies #303

Closed
wants to merge 1 commit into from

Conversation

pvomacka
Copy link

@pvomacka pvomacka commented Dec 2, 2016

Python-pyasn1-modules is required by python-ldap package, but it would be
good to not rely on another package and rather say explicitely, that
this package is necessary.

https://fedorahosted.org/freeipa/ticket/6398

@tiran
Copy link
Member

tiran commented Dec 2, 2016

Good idea, please add BuildRequires for the package, too.

Python-pyasn1-modules is needed because of this import:
     from pyasn1_modules import rfc2459
in ipalib/x509.py.

Python-pyasn1-modules is required only by python-ldap package, but it would be
good to not rely on another package and rather say explicitely that
this package is necessary.

https://fedorahosted.org/freeipa/ticket/6398
@pvomacka
Copy link
Author

pvomacka commented Dec 5, 2016

Added, I also added more information into commit message.

@tiran tiran added the ack Pull Request approved, can be merged label Dec 5, 2016
@martbab
Copy link
Contributor

martbab commented Dec 5, 2016

@martbab martbab added the pushed Pull Request has already been pushed label Dec 5, 2016
@martbab martbab closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants