Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowered the version of gettext #307

Closed
wants to merge 1 commit into from
Closed

Conversation

pvomacka
Copy link

@pvomacka pvomacka commented Dec 5, 2016

The lower version is needed while building on RHEL.
Also regenerated Rules-quot file.

https://fedorahosted.org/freeipa/ticket/6418

@pspacek
Copy link
Contributor

pspacek commented Dec 5, 2016

If the file Rules-quot is generated by autoreconf -i, please remove it completely and add it into .gitignore.

@pspacek pspacek added ack Pull Request approved, can be merged and removed ack Pull Request approved, can be merged labels Dec 8, 2016
@pspacek
Copy link
Contributor

pspacek commented Dec 8, 2016

@pvomacka Pavel, you did not remove the po/Rules-quot file. Adding it to .gitignore is not enough.

NACK (sorry for messing with the label, too fat fingers)

The lower version is needed while building on RHEL.
Also po/Rules-quot file is deleted and added to .gitignore.

https://fedorahosted.org/freeipa/ticket/6418
@pspacek pspacek added the ack Pull Request approved, can be merged label Dec 9, 2016
@pspacek pspacek self-requested a review December 9, 2016 08:40
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Dec 9, 2016
@MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants