WebUI: add support for sub-CAs while revoking certificates and removing certificate hold #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 26, 2016 13:54
Sometimes the entity_show command must be called with options which are gathered from result of entity_find command. These options needs to be passed as arguments in URL which points to details page. This functionality is implemented to table facet. There is new property 'additional_navigation_arguments' which is prepared for array of attributes which will be passed to URL. Part of: https://fedorahosted.org/freeipa/ticket/6238
The cert-show command needs to be called with cacn option. Cacn option is passed using URL attribute. https://fedorahosted.org/freeipa/ticket/6238
Also the same for removing certificate hold. https://fedorahosted.org/freeipa/ticket/6216
|
nack for f72ae94 it needs this update diff --git a/install/ui/src/freeipa/certificate.js b/install/ui/src/freeipa/certificate.js
index ad7fd87..9ab4002 100755
--- a/install/ui/src/freeipa/certificate.js
+++ b/install/ui/src/freeipa/certificate.js
@@ -268,6 +268,7 @@ IPA.cert.revoke_dialog = function(spec, no_init) {
spec = spec || {};
spec.width = spec.width || 500;
+ spec.ok_label = spec.ok_label || '@i18n:buttons.revoke';
spec.sections = [
{
name: 'note',
@@ -308,12 +309,13 @@ IPA.cert.revoke_dialog = function(spec, no_init) {
}
];
- var that = IPA.dialog(spec);
+ var that = IPA.confirm_dialog(spec);
that.open = function() {
+
+ that.confirmed = false;
that.dialog_open();
that.set_cacn(that.facet.state.cacn);
-
};
that.get_reason = function() {
@@ -336,23 +338,6 @@ IPA.cert.revoke_dialog = function(spec, no_init) {
that.init = function() {
var note = text.get('@i18n:objects.cert.revoke_confirmation');
that.widgets.get_widget('note.note').html = note;
-
- that.create_button({
- name: 'revoke',
- label: '@i18n:buttons.revoke',
- click: function() {
- that.on_ok();
- that.close();
- }
- });
-
- that.create_button({
- name: 'cancel',
- label: '@i18n:buttons.cancel',
- click: function() {
- that.close();
- }
- });
};
ACK for 8622b9f and e874ac9 (#6238) I'll create new separate pull requests for both #6238 and #6216. So that #6238 can be pushed and aforementioned changes for #6216 reviewed. |
This was referenced Sep 6, 2016
Closed
|
Obsoleted by pull request #65 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revocation dialog has new field for setting a CA and these patches also fix showing details of certificates issued by sub-CAs.
https://fedorahosted.org/freeipa/ticket/6216
https://fedorahosted.org/freeipa/ticket/6238