bindinstance: use LDAP to determine configuration status #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking sysrestore status which leads to incorrect evaluation of DNS configuration status during 4.2 -> 4.4 upgrade, use server roles API to query DNS server role status on the master. Use the default implementation only if LDAP connection is unavailable or stale. https://fedorahosted.org/freeipa/ticket/6503
pspacek
suggested changes
Dec 6, 2016
There was a problem hiding this comment.
Given that this is going to 4.4 branch it would be better to keep changes minimal. Please use something which looks into /etc/named.conf instead of LDAP, it will be less fragile.
LDAP usage will require systematic changes in upgrade & uninstall as we discussed in person.
|
OK I will then close this PR and create a separate one against ipa-4-4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking sysrestore status which leads to incorrect
evaluation of DNS configuration status during 4.2 -> 4.4 upgrade, use
server roles API to query DNS server role status on the master.
Use the default implementation only if LDAP connection is unavailable or
stale.
https://fedorahosted.org/freeipa/ticket/6503