Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing attribute to ipaca replica during CA topology update #320

Closed
wants to merge 2 commits into from

Conversation

martbab
Copy link
Contributor

@martbab martbab commented Dec 7, 2016

The previous fix for missing 'nsds5replicabinddngroupcheckinterval' fails when
the first CA master is being set up. The attribute addition from update file
has to be moved to the update plugin with a proper logic that determines the
presence of o=ipaca replica entry.

https://fedorahosted.org/freeipa/ticket/6508

Martin Babinsky added 2 commits December 7, 2016 17:23
…ogy config"

This reverts commit 8c6a10c since it
leads to errors in upgrade of first master.

https://fedorahosted.org/freeipa/ticket/6508
'nsds5replicabinddngroupcheckinterval' attribute was not properly added
to 'o=ipaca' replica attribute during upgrade. The CA topology update
plugin should now add it to the entry if it exists.

https://fedorahosted.org/freeipa/ticket/6508
@MartinBasti MartinBasti self-requested a review December 8, 2016 11:38
@MartinBasti MartinBasti self-assigned this Dec 8, 2016
@MartinBasti
Copy link
Contributor

IMO #322 this might be related, @martbab can you please check it?

@martbab
Copy link
Contributor Author

martbab commented Dec 9, 2016

@tbordaz mentioned that this fix is better and that we should discard #322. Please continue review.

@martbab
Copy link
Contributor Author

martbab commented Dec 9, 2016

@mbasti-rh also this PR solves a bit different issue that the others (#315 and #319) and that is that the upgrade path for CA replicas was broken. It supplements the two PR so that everything is set up correctly also for o=ipaca suffix, not only the domain one.

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Dec 9, 2016
@martbab martbab added the pushed Pull Request has already been pushed label Dec 9, 2016
@martbab martbab closed this Dec 9, 2016
@martbab martbab deleted the ca-topology-update-fix branch December 16, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants