Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Bump PR-CI template version #3225

Closed
wants to merge 1 commit into from
Closed

[master] Bump PR-CI template version #3225

wants to merge 1 commit into from

Conversation

netoarmando
Copy link
Member

This PR replaces #3210, since that is falling due to Fedora 30 issues.

These changes update the image used by PR-CI, but Fedora 29 will be used still for gating while #3216 is not ready.

Signed-off-by: Armando Neto <abiagion@redhat.com>
@netoarmando netoarmando added prioritized Pull Request has higher priority for PR-CI needs review Pull Request is waiting for a review labels Jun 3, 2019
@flo-renaud flo-renaud self-assigned this Jun 4, 2019
@flo-renaud
Copy link
Contributor

Hi @netoarmando
I have a few questions related to this PR: ci-master-f29 / ci-master-f28 vagrant box version is updated to 0.2.1 but there is a 0.2.2 version available on app.vagrantup.com (but strangely 0.2.1 is more recent than 0.2.2). Could you clarify?
It could be beneficial to add more comments on the box definition when a new box is uploaded, describing the difference with the previous version.

@netoarmando
Copy link
Member Author

@flo-renaud I've built two new releases for every box, both with the Python 3 changes, but one with SELinux disable and other with SELinux in permissive mode. That is already included in the release descriptions on vagrantup.com. But I'm including right now the hash used to build the boxes.

I disabled SELinux because of freeipa/freeipa-pr-ci#266.

Most recent releases have SELinux in permissive mode because this is something we must fix soon, I've built those boxes to troubleshoot the issue.

@flo-renaud
Copy link
Contributor

Hi @netoarmando
thanks for the clarification, works for me. ACK.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Jun 4, 2019
@netoarmando netoarmando added the pushed Pull Request has already been pushed label Jun 4, 2019
@netoarmando
Copy link
Member Author

master:

  • c0d4088 Bump PR-CI template version

@netoarmando netoarmando closed this Jun 4, 2019
@netoarmando netoarmando deleted the bump-prci-template-version branch June 4, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged prioritized Pull Request has higher priority for PR-CI pushed Pull Request has already been pushed
Projects
None yet
2 participants