Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipactl: pass api as argument to services #323

Closed
wants to merge 1 commit into from
Closed

ipactl: pass api as argument to services #323

wants to merge 1 commit into from

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Dec 9, 2016

Commit 6409abf removes hard dependency of ipalib in ipalatform to avoid
cyclic dependenies, this commit updates ipactl accordingly

Removes ugly warnings:

[root@vm-028 ~]# ipactl stop
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa-dnskeysyncd', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping ipa-dnskeysyncd Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa-otpd', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping ipa-otpd Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatCAService('pki-tomcatd', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping pki-tomcatd Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ntpd', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping ntpd Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa-custodia', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping ipa-custodia Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('httpd', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping httpd Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa_memcached', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping ipa_memcached Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('named', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping named Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('kadmin', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)
Stopping kadmin Service
/usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('krb5kdc', api=None) is deprecated.
  super(SystemdService, self).__init__(service_name, api=api)

Commit 6409abf removes hard dependency of ipalib in ipalatform to avoid
cyclic dependenies, this commit updates ipactl accordingly
@stlaz
Copy link
Contributor

stlaz commented Dec 12, 2016

Do we need a ticket for this? I notice the original commit did not have it either.

@MartinBasti
Copy link
Contributor Author

I don't know

@stlaz
Copy link
Contributor

stlaz commented Dec 12, 2016

Works as expected. ACK.

@stlaz stlaz added the ack Pull Request approved, can be merged label Dec 12, 2016
@MartinBasti
Copy link
Contributor Author

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Dec 12, 2016
@MartinBasti MartinBasti deleted the fix-ipactl branch December 12, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants