adtrust: remove FILE: prefix from 'dedicated keytab file' in smb.conf #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbra
force-pushed
the
samba-4.5-fixes
branch
from
04aba48
to
93c1e57
Compare
martbab
reviewed
Dec 12, 2016
| @@ -1653,6 +1674,7 @@ def upgrade_configuration(): | |||
|
|
|||
| cleanup_kdc(fstore) | |||
| cleanup_adtrust(fstore) | |||
| upgrade_atrust_config() | |||
There was a problem hiding this comment.
Typo here, should be upgrade_adtrust_config
|
Pylint complaints about undefined function because you made a typo. |
abbra
force-pushed
the
samba-4.5-fixes
branch
from
93c1e57
to
74fcf5c
Compare
|
Thanks, fixed it. |
|
The branch needs a rebase. Otherwise works as expected and has no PEP8 errors despite what crazy Travis CI claims. |
Samba 4.5 does not allow to specify access mode for the keytab (FILE: or
WRFILE:) from external sources. Thus, change the defaults to a path
(implies FILE: prefix) while Samba Team fixes the code to allow the
access mode prefix for keytabs.
On upgrade we need to replace 'dedicated keytab file' value with the
path to the Samba keytab that FreeIPA maintains. Since the configuration
is stored in the Samba registry, we use net utility to manipulate the
configuration:
net conf setparm global 'dedicated keytab file' /etc/samba/samba.keytab
Fixes https://fedorahosted.org/freeipa/ticket/6551
abbra
force-pushed
the
samba-4.5-fixes
branch
from
74fcf5c
to
912b131
Compare
|
Rebased to git master. |
|
Fixed upstream |
|
Rebased and pushed to ipa-4-4 https://fedorahosted.org/freeipa/changeset/fd8c17252fbc3efccad66cdcd373195c0fc53ce3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samba 4.5 does not allow to specify access mode for the keytab (FILE: or
WRFILE:) from external sources. Thus, change the defaults to a path
(implies FILE: prefix) while Samba Team fixes the code to allow the
access mode prefix for keytabs.
On upgrade we need to replace 'dedicated keytab file' value with the
path to the Samba keytab that FreeIPA maintains. Since the configuration
is stored in the Samba registry, we use net utility to manipulate the
configuration:
Fixes https://fedorahosted.org/freeipa/ticket/6551