Minimal test suite for kadmin.local #346
Conversation
This allows for diagnose the output and error code of these operations. Otherwise there is no way to infer their success or failure apart from inspecting logs post-mortem. https://fedorahosted.org/freeipa/ticket/6561
This small integration suite tests some basic operations using kadmin.local interface on services in both kerberos and services subtree. https://fedorahosted.org/freeipa/ticket/6561
| to catch the command's stderr and check that it is empty | ||
| """ | ||
| result = command(*args) | ||
| assert not result.error_output |
There was a problem hiding this comment.
Shouldnt be here tested rather return code than stderr?
There was a problem hiding this comment.
In the last case, there was a Kerberos internal database error but the return code was still 0 (also pointed out in the comment). I wonder, could this cause issues should Kerberos throw some warnings on stderr or do we assume no warnings should be present at all at any time?
There was a problem hiding this comment.
Warnings are also thrown in stderr (e.g. when no password policy was specified) but they are not tested in this case as they are part of setup. The problem here is, as Standa pointed out, that if the query fails, kardmin still returns 0, so testing for the presence of stderr is still the sanest way to assert command success. But I can re-implement the test to assert success by expecting certain messages in stdout if you wish.
There was a problem hiding this comment.
Ah, OK blind me a didn't see the commet, ACK
This ensures that we do not break it (much) in the
future like we did recently
https://fedorahosted.org/freeipa/ticket/6561