Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509: use PyASN1 to parse PKCS#7 #360

Closed
wants to merge 1 commit into from
Closed

x509: use PyASN1 to parse PKCS#7 #360

wants to merge 1 commit into from

Conversation

HonzaCholasta
Copy link
Contributor

@HonzaCholasta HonzaCholasta commented Dec 21, 2016

Use PyASN1 with the PKCS#7 definitions from pyasn1_modules to parse
PKCS#7 in pkcs7_to_pems() instead of calling openssl pkcs7 in a
subprocess.

https://fedorahosted.org/freeipa/ticket/6550

Use PyASN1 with the PKCS#7 definitions from `pyasn1_modules` to parse
PKCS#7 in `pkcs7_to_pems()` instead of calling `openssl pkcs7` in a
subprocess.

https://fedorahosted.org/freeipa/ticket/6550
Copy link
Contributor

@frasertweedale frasertweedale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

(CI failure appears unrelated... if so, ACK).

@martbab
Copy link
Contributor

martbab commented Dec 22, 2016

The failure comes from occasional hiccups in Travis CI DNS infra.

@martbab martbab added the ack Pull Request approved, can be merged label Dec 22, 2016
@martbab
Copy link
Contributor

martbab commented Dec 22, 2016

@martbab martbab added the pushed Pull Request has already been pushed label Dec 22, 2016
@martbab martbab closed this Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants