Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meaning of --domain and --realm in installers #362

Closed
wants to merge 1 commit into from
Closed

Clarify meaning of --domain and --realm in installers #362

wants to merge 1 commit into from

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Jan 2, 2017 •
edited by MartinBasti

This is my take on original #352. I hope I fixed all the mentioned issues + I added some missing articles.

@frasertweedale
Copy link
Contributor

All of my comments from #352 were addressed.

@stlaz you were the only other person to review #352 and request changes, so I assume
you have addressed those too, in which case: ACK.

@stlaz stlaz added the ack Pull Request approved, can be merged label Jan 4, 2017
@stlaz stlaz mentioned this pull request Jan 4, 2017
Closed
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Jan 5, 2017
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/25a6ddcce8e7b9effaf19431c421dc5b3497fa22

@MartinBasti MartinBasti closed this Jan 5, 2017
@stlaz stlaz deleted the domainclarity branch September 11, 2017 10:48
@stlaz stlaz restored the domainclarity branch September 11, 2017 10:48
@stlaz stlaz deleted the domainclarity branch April 6, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@stlaz @frasertweedale @MartinBasti