Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch ValueError raised by pytest.config.getoption() #369

Closed
wants to merge 1 commit into from
Closed

Catch ValueError raised by pytest.config.getoption() #369

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 4, 2017 •
edited by MartinBasti

pytest.config.getoption() can raise ValueError for unknown options, too.

I ran into the issue while I was working on PR #366

@tiran
Catch ValueError raised by pytest.config.getoption()
ab23ce2 
pytest.config.getoption() can raise ValueError for unknown options, too.
@apophys apophys self-assigned this Jan 5, 2017
@apophys apophys self-requested a review January 5, 2017 10:47
@apophys apophys removed their assignment Jan 5, 2017
@apophys apophys added the ack Pull Request approved, can be merged label Jan 5, 2017
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Jan 5, 2017
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/3387734e6c6d47a756b5e914e7e515d2610a424f

@MartinBasti MartinBasti closed this Jan 5, 2017
@tiran tiran deleted the pytest_getoption branch January 5, 2017 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apophys apophys apophys approved these changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @MartinBasti @apophys