Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean / ignore make check artefact #378

Closed
wants to merge 1 commit into from
Closed

Clean / ignore make check artefact #378

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 9, 2017 •
edited by martbab

make check runs cmocka tests for our C code. The patch also adds some
additional files to gitignore and cleanup.

Signed-off-by: Christian Heimes cheimes@redhat.com

@martbab
Copy link
Contributor

martbab commented Jan 9, 2017

IIRC cmocka tests are already ran as a part of build process, seee the following excerpt from the build log:

<SNIP>
PASS: ipa_kdb_tests                                                            
============================================================================   
Testsuite summary for freeipa 4.4.90.dev201701091412+git5dd9c32                
============================================================================   
# TOTAL: 1                                                                     
# PASS:  1                                                                     
# SKIP:  0                                                                     
# XFAIL: 0                                                                     
# FAIL:  0                                                                     
# XPASS: 0                                                                     
# ERROR: 0                                                                     
============================================================================
<SNIP>

I am not sure if we need to run them as a separate step right now.

@tiran
Copy link
Member Author

tiran commented Jan 11, 2017

The changes to .gitignore and clean-local are still required to fix in-tree testing. make check leaves some files around.

@tiran
Clean / ignore make check artefact
91450e2 
In tree runs of make check leave some artifacts around. The patch adds
them to make clean and .gitignore.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran changed the title Integrate make check into CI Clean / ignore make check artefact Jan 11, 2017
@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Jan 16, 2017
@martbab
Copy link
Contributor

martbab commented Jan 18, 2017

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/d8343a96dd206c9f25cf032a50f3b48fb8166db1

@martbab martbab added the pushed Pull Request has already been pushed label Jan 18, 2017
@martbab martbab closed this Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @martbab @MartinBasti