Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Add IPA commands package #379

Closed
wants to merge 1 commit into from
Closed

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 9, 2017

The ipacommands package contains ipa-getkeytab and ipa-rmkeytab for
installation in a virtual env. The programs are compiled with distutils
/ setuptools.

The ipa and freeipa packages are placeholders to prevent PyPI squashing
attacks and reserve the names for future use. pip install ipa installs
ipaclient.

https://fedorahosted.org/freeipa/ticket/6484

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran
Copy link
Member Author

tiran commented Jan 23, 2017

The ipa and freeipa packages are necessary to prevent typo squatting or name squatting attacks, e.g. http://arstechnica.com/security/2016/06/college-student-schools-govs-and-mils-on-perils-of-arbitrary-code-execution/ . We want to make sure that a developer gets FreeIPA when he does pip install freeipa.

I already reserved the names on PyPI. It is necessary to upload new packages for ipa and freeipa regularly. Otherwise PyPI considers our packages obsolete and may remove them. See https://www.python.org/dev/peps/pep-0541/

@pvoborni
Copy link
Member

I thought that I understand why this PR is needed bud in fact I don't. Ticket #6484 is closed. Why is it attached to it?

How will the pypi packaging change if ipacommands package is not there? Would it be used for anything? How it should be used?

@MartinBasti
Copy link
Contributor

We need placeholder package for sure, this PR should be splitted into 2, but I'm still not endorsed to have ipa-getkeytab installable by pip

@tiran
Copy link
Member Author

tiran commented Feb 14, 2017

I don't mind to maintain my own copy of ipacommands with ipa-getkeytab until we agree on a permanent solution.

@pvoborni
Copy link
Member

If there is reason it can be maintained in IPA, but what is the reason?

@tiran
Copy link
Member Author

tiran commented Feb 23, 2017

I have postponed the ipacommands part. Placeholders are covered by #472.

@tiran tiran changed the title Packaging: Add placeholder and IPA commands packages Packaging: Add IPA commands package Mar 16, 2017
@tiran tiran removed the postponed label Mar 16, 2017
@MartinBasti MartinBasti removed their assignment May 26, 2017
@tkrizek
Copy link
Contributor

tkrizek commented Aug 29, 2017

Closing for inactivity. If this PR is still relevant, please re-open it.

@tkrizek tkrizek closed this Aug 29, 2017
@tkrizek tkrizek added the rejected Pull Request has been rejected label Aug 29, 2017
@tiran tiran reopened this Aug 29, 2017
@tkrizek tkrizek removed the rejected Pull Request has been rejected label Aug 29, 2017
The ipacommands package contains ipa-getkeytab and ipa-rmkeytab for
installation in a virtual env. The programs are compiled with distutils
/ setuptools.

https://fedorahosted.org/freeipa/ticket/6484

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added the re-run Trigger a new run of PR-CI label Nov 20, 2017
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Nov 20, 2017
@tiran
Copy link
Member Author

tiran commented Dec 7, 2017

This PR will probably never land.

@tiran tiran closed this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants