py3: enable py3 pylint #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
ack
tiran
requested changes
Jan 11, 2017
| @@ -40,7 +40,8 @@ steps: | |||
| -a ${server_password} --setup-dns --auto-forwarders | |||
| - ipa-kra-install -p ${server_password} | |||
| lint: | |||
| - make V=0 lint | |||
| - PYTHON=/usr/bin/python2 make V=0 lint | |||
| - PYTHON=/usr/bin/python3 make V=0 lint | |||
There was a problem hiding this comment.
please make the python3 target pylint only. I just realized that lint also runs the i18n and JS linters.
There was a problem hiding this comment.
I don't think that running those linters twice is an issue, but as you wish I updated PR
We should run pylint in both python2 and python3 versions
|
It's just a minor performance improvements to speed up CI. |
tiran
approved these changes
Jan 11, 2017
|
Lint part of travis-CI passed |
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should run pylint in both python2 and python3 versions