Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build in mock #389

Closed
wants to merge 3 commits into from
Closed

Fix build in mock #389

wants to merge 3 commits into from

Conversation

lslebodn
Copy link
Contributor

No description provided.

@tiran
Copy link
Member

tiran commented Jan 11, 2017

Thanks, your PR fixes some concerns of my ticket https://fedorahosted.org/freeipa/ticket/6604.

Lukas Slebodnik added 3 commits January 11, 2017 18:16
If configure script was executed with --enable-pylint then
it behaved the same as --disable-pylint. It does not make
any sense.

Resolves:
https://fedorahosted.org/freeipa/ticket/6604
Neither pylint nor jsl is installed by default because rpm macro with_lint
is not defined in spec file. However, configure script tried to
find pylint/jsl anyway.

  checking for Pylint... /usr/bin/python2: No module named pylint
  configure: error: cannot find pylint for /usr/bin/python2

  RPM build errors:
  error: Bad exit status from /var/tmp/rpm-tmp.2GAFh4 (%build)
      Bad exit status from /var/tmp/rpm-tmp.2GAFh4 (%build)

Resolves:
https://fedorahosted.org/freeipa/ticket/6604
@lslebodn
Copy link
Contributor Author

I updated doc help do jslint in latest version

@lslebodn
Copy link
Contributor Author

@tiran or @pvomacka, @tomaskrizek It would be good if you could test/ack the latest version of the patch.
Because currently it is not possible to build freeIPA with upstream spec file in mock; which blocks reasonable testing with static analysers

@tkrizek tkrizek self-assigned this Jan 17, 2017
@tkrizek
Copy link
Contributor

tkrizek commented Jan 17, 2017

Thanks for the fix and explanation!

@tkrizek tkrizek added the ack Pull Request approved, can be merged label Jan 17, 2017
@martbab martbab closed this Jan 18, 2017
@martbab martbab added the pushed Pull Request has already been pushed label Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants