tests: Add LDAP URI to ldappasswd explicitly #404
Conversation
|
|
MartinBasti
changed the title
Test should always respect api.env.* values. https://fedorahosted.org/freeipa/ticket/6622
|
@tiran Nice catch, I've added it to ipatests/test_integration/util.py, too. but I would rather not extend this outside of tests. |
|
@tiran After a closer look I believe that it's handled correctly in ipaserver/install/service.py |
|
I stand corrected! Thanks David. |
| @@ -86,5 +87,5 @@ def ldappasswd_user_change(user, oldpw, newpw, master): | |||
| userdn = "uid={},{},{}".format(user, container_user, basedn) | |||
|
|
|||
| args = [paths.LDAPPASSWD, '-D', userdn, '-w', oldpw, '-a', oldpw, | |||
| '-s', newpw, '-x'] | |||
| '-s', newpw, '-x', '-H', api.env.ldap_uri] | |||
There was a problem hiding this comment.
Have you tested this?
This code is executed on controller machine, thus api.env may be undefined, because there is no installed IPA.
I'm not sure if ldap_uri may be diferent on each (I assume than ldapi URI is the same on all machines, but not ldaps)
There was a problem hiding this comment.
@MartinBasti I agree with your concerns. I guess constructed LDAP URI from passed in master parameter sounds as a safer bet.
ghost
mentioned this pull request
ghost
closed this
Test should always respect api.env.* values.
https://fedorahosted.org/freeipa/ticket/6622