Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] ipatests: filter_users should be applied correctly if SSSD starts offline #4052

Closed
wants to merge 2 commits into from

Conversation

amore17
Copy link
Contributor

@amore17 amore17 commented Dec 17, 2019

This is manual back-port of : #3349

@flo-renaud
Copy link
Contributor

Hi @amore17
pylint failed with

************* Module ipatests.test_integration.test_sssd

ipatests/test_integration/test_sssd.py:16: [E0611(no-name-in-module), ] No name 'osinfo' in module 'ipaplatform')

ipatests/test_integration/test_sssd.py:16: [E0401(import-error), ] Unable to import 'ipaplatform.osinfo')

You will need to adapt the PR because osinfo was introduced after ipa-4-6.

@amore17 amore17 force-pushed the filterbackport4-6 branch 3 times, most recently from 5978a21 to 35da5ea Compare December 17, 2019 09:30
@amore17 amore17 added the needs review Pull Request is waiting for a review label Dec 17, 2019
@tiran

This comment has been minimized.

@amore17 amore17 force-pushed the filterbackport4-6 branch 2 times, most recently from 9076ff2 to 79e5bbf Compare December 17, 2019 12:42
@amore17
Copy link
Contributor Author

amore17 commented Dec 18, 2019

@flo-renaud As per suggestion of @tiran I have removed back-port of 1dadcd6 and added xfail in another commit as sssd bulids are not available in fedora-27

Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amore17

ipatests/test_integration/test_sssd.py Show resolved Hide resolved
@flo-renaud flo-renaud self-assigned this Dec 18, 2019
@flo-renaud flo-renaud removed the needs review Pull Request is waiting for a review label Dec 18, 2019
@amore17
Copy link
Contributor Author

amore17 commented Dec 18, 2019

Hi @amore17

* the nightly definition needs to be updated in order to execute this test (ipatests/prci_definitions/nightly_ipa-4-6.yaml)

* The backport also takes the tests from #3602 but this was not planned for ipa-4-6, are you sure you need the whole file?

Adding postponed label.
As there is test which is part of #3602 which is not back-ported yet to ipa-4-6
Pending review on @wladich

@amore17 amore17 force-pushed the filterbackport4-6 branch 3 times, most recently from f4632c6 to c679de2 Compare February 14, 2020 08:26
@amore17 amore17 removed the postponed label Feb 14, 2020
@flo-renaud
Copy link
Contributor

Hi @amore17
the backport looks ok but you should add a temp commit to launch the test in PRCI and check that it is properly marked as xfail.

@freeipa-pr-ci freeipa-pr-ci added the needs rebase Pull Request cannot be automatically merged - needs to be rebased label Feb 14, 2020
Added test which checks that no look up should
be added in data provider when users are added in
filter_users for doamin provider.

Related Ticket:
https://pagure.io/SSSD/sssd/issue/3978

Signed-off-by: Anuja More <amore@redhat.com>
As fix is not available in f27 marking test as xfail.
reason: https://pagure.io/SSSD/sssd/issue/3978

Signed-off-by: Anuja More <amore@redhat.com>
@amore17 amore17 added needs review Pull Request is waiting for a review and removed needs rebase Pull Request cannot be automatically merged - needs to be rebased labels Feb 14, 2020
@flo-renaud
Copy link
Contributor

Hi @amore17
thanks for the update. The test was properly marked as xfailed, you can remove the temp commit.

@flo-renaud flo-renaud removed the needs review Pull Request is waiting for a review label Feb 17, 2020
@amore17 amore17 added the needs review Pull Request is waiting for a review label Feb 17, 2020
@flo-renaud flo-renaud added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Feb 17, 2020
@flo-renaud
Copy link
Contributor

Hi @amore17
thanks for the update, tests are green, ACK.

@fcami fcami added the pushed Pull Request has already been pushed label Feb 17, 2020
@fcami
Copy link
Contributor

fcami commented Feb 17, 2020

ipa-4-6:

  • 4b70132 ipatests: filter_users should be applied correctly.
  • d3b740e Mark xfail for test_is_user_filtered

@fcami fcami closed this Feb 17, 2020
@amore17 amore17 deleted the filterbackport4-6 branch July 28, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
5 participants