Update warning message for replica install #421
Conversation
|
Hello, I'd not omit the fact, that insufficient privilege error can be be caused by user credentials as well, I also wouldn't mention that hostgroup must exists explicitly. I propose something like this, but I'm open to any suggestions and improvements |
|
@MartinBasti I am OK for changing the warning message. I will wait for other to comment. |
| raise ScriptError("\nInsufficient privileges to promote the server.") | ||
| raise ScriptError("\nInsufficient privileges to promote the server." | ||
| "\nPossible issues:" | ||
| "\n- An user has insufficient privileges" |
There was a problem hiding this comment.
"A user" - you use the article depending on the pronunciation of the following word.
| raise ScriptError("\nInsufficient privileges to promote the server." | ||
| "\nPossible issues:" | ||
| "\n- An user has insufficient privileges" | ||
| "\n- Thin Client has insufficient privileges " |
| "\nPossible issues:" | ||
| "\n- An user has insufficient privileges" | ||
| "\n- Thin Client has insufficient privileges " | ||
| "to become IPA Replica Server") |
There was a problem hiding this comment.
"s/IPA Replica Server/an IPA replica"
| raise ScriptError("\nInsufficient privileges to promote the server." | ||
| "\nPossible issues:" | ||
| "\n- A user has insufficient privileges" | ||
| "\n- This Client has insufficient privileges " |
There was a problem hiding this comment.
Please, have the "C" in "Client" lowercased and I'll ACK this :)
New warning message in replica install describes more about "insufficient privilege" error Fixes https://fedorahosted.org/freeipa/ticket/6352 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
Wonderful, thank you for your patch. |
|
Fixed upstream |
|
@stlaz Thanks for your comments. |
|
@MartinBasti Thanks for your comments. |
New warning message in replica install describes more about
"insufficient privilege" error
Fixes https://fedorahosted.org/freeipa/ticket/6352
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com