DNSSEC: forwarders validation improvement #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some DNS servers behaves oddly and instead sending result without RRSIG records don't reply at all when DNSSEC flag is enabled (timeout). Instead of hard error IPA should this handle as DNSSEC error and continue with installation/adding forwarders.
tkrizek
suggested changes
Feb 7, 2017
| @@ -670,8 +670,7 @@ def validate_dnssec_global_forwarder(ip_addr, log=None, timeout=10): | |||
| timeout=timeout) | |||
| except DNSException as e: | |||
| _log_response(log, e) | |||
| raise UnresolvableRecordError(owner=owner, rtype=rtype, ip=ip_addr, | |||
| error=e) | |||
| raise DNSSECSignatureMissingError(owner=owner, rtype=rtype, ip=ip_addr) | |||
There was a problem hiding this comment.
Please update the docstring since the function no longer raises UnresolvableRecordError.
There was a problem hiding this comment.
It still can due _validate_edns0_forwarder() call
|
I think the same issue can also occur in |
|
I was thinking about it and I disagree. Checking forwards zone behaves differently than check for global forwarders. The validate |
tkrizek
approved these changes
Feb 8, 2017
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DNS servers behaves oddly and instead sending result without RRSIG records
don't reply at all when DNSSEC flag is enabled (timeout). Instead of
hard error IPA should this handle as DNSSEC error and continue with
installation/adding forwarders.