[py3] ipactl restart: log httplib failues as debug #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
previously requested changes
Jan 31, 2017
ipapython/dogtag.py
Outdated
| @@ -209,7 +210,8 @@ def _httplib_request( | |||
| http_body = res.read() | |||
| conn.close() | |||
| except Exception as e: | |||
| root_logger.exception("httplib request failed:") | |||
| root_logger.debug("httplib request failed") | |||
There was a problem hiding this comment.
Instead of traceback.format.exc(), use root_logger.debug("httplib request failed", exc_info=True) to log message with traceback.
|
This happens with python2.7 too, I reproduced it today |
|
Yeah, I reported the issue as https://fedorahosted.org/freeipa/ticket/6674 . Feel free to close it as duplicate. |
|
I don't see what this has to do with Py3. The issue is the same on Py2. Swap the ticket for the one of @tiran and I'll ack this. If this gets triaged for 4.4 as well we can backport it later. |
There are several excerptions ConnectionRefusedError raised before ipactl is able to connect to dogtag after restart. These exception should be logged on debug level until timeout is reached. https://fedorahosted.org/freeipa/ticket/6674
|
Ticket corrected, commit msg ammended |
|
Thanks, ACK. |
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With python3 there are several excerptions ConnectionRefusedError raised
before ipactl is able to connect to dogtag after restart. These
exception should be logged on debug level until timeout is reached.
https://fedorahosted.org/freeipa/ticket/4985