Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add missing dependency on libxmlrpc{,_util} #432

Closed
wants to merge 1 commit into from
Closed

build: Add missing dependency on libxmlrpc{,_util} #432

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2017 •
edited by MartinBasti

Change in libxmlrpc packaging uncovered missing linking dependency in our
build system.

https://fedorahosted.org/freeipa/ticket/6637

build: Add missing dependency on libxmlrpc{,_util}
cf82029 
Change in libxmlrpc packaging uncovered missing linking  dependency in our
build system.

https://fedorahosted.org/freeipa/ticket/6637
@ghost ghost requested a review from pvomacka February 2, 2017 12:32
@ghost ghost assigned pvomacka Feb 2, 2017
@tiran
Copy link
Member

tiran commented Feb 6, 2017

ACK

ipa-join uses functions from libxmlrpc.so (e.g. xmlrpc_string_new) and from libxmlrpc_util.so (e.g. xmlrpc_env_init). In the past it was no problem because libxmlrpc_client.so depends on both libraries and pulled the function in. Nowadays indirect linking triggers a DSO error. All libraries must be linked directly.

@pvomacka pvomacka added the ack Pull Request approved, can be merged label Feb 6, 2017
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/f4088b3a00b3cbd1a0133ac90cba85e501573f76

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Feb 6, 2017
@MartinBasti MartinBasti closed this Feb 6, 2017
@MartinBasti
Copy link
Contributor

Needs separate PR for ipa-4-4 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvomacka pvomacka Awaiting requested review from pvomacka

Assignees

@pvomacka pvomacka

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @MartinBasti @pvomacka