Testing both py2/py3 in travis #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
changed the title
MartinBasti
changed the title
stlaz
reviewed
Jun 20, 2017
freeipa.spec.in
Outdated
| @@ -17,11 +17,15 @@ | |||
| %global with_ipatests_option --without-ipatests | |||
| %endif | |||
|
|
|||
| %if 0%{?with_python3:1} | |||
| # with_python3 already defined | |||
| %else | |||
There was a problem hiding this comment.
You can make these three lines into one if you change the original condition to %if 0%{!?with_python3:1}
|
Otherwise LGTM |
This is more or less for testing purposes of py2/py3 compatibility
We will testing both py2 and py3 packages, first step is use only py2 builds for testing py2 packages
This testconfig is temporary until all plugins are migrated into py3. After that this temporal config file will be removed and used only the previous one again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less for testing purposes of py2/py3 compatibility