certdb: remove unused keysize property #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to remove them, you may want to check for other properties as well (I see |
Keysize property is no longer used anywhere in the code. It was originally introduced for the request_cert function, which was later refactored to use a function argument instead.
tkrizek
force-pushed
the
remove-ununsed-certdb-keysize
branch
from
1de9bfd
to
3877bbb
Compare
|
Commit that removed valid_moths property: e736e75 |
|
Conditional ACK: just fix the typo |
Property valid_months is no longer used anywhere in the code. It was removed when the selfsign funcionality was dropped.
tkrizek
force-pushed
the
remove-ununsed-certdb-keysize
branch
from
3877bbb
to
0184b7f
Compare
|
@frasertweedale Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keysize property is no longer used anywhere in the code. It was
originally introduced for the request_cert function, which was later
refactored to use a function argument instead.
The value of this property caught my eye, because I don't think we should be using 1024bit keys. Fortunately, I discovered this bit of code is obsolete and we actually use 2048bit key length by default.
Commit that originally introduced the property: 158b4e8
Commit that removed the usage of the property: 9182c10