[ WIP] ipa-run-tests: allow to run tests with server-api #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to test server-api with ipa-run-tests. It is useful because internal error tracebacks are printed to test output and it is handy to use it with python -bb option to check BytesWarnings
tiran
reviewed
Feb 8, 2017
| dest="ipa_in_server", | ||
| type=truefalse, | ||
| choices=(True, False), | ||
| default=False, |
There was a problem hiding this comment.
You don't need to go the complicated route like in PR #442. Please replace type, choices and default with a simple action='store_true, https://docs.python.org/3/library/argparse.html#action
There was a problem hiding this comment.
sure, but there are more issues I have to solve than this one :) still WIP
|
There are too many issues, it is not possible to run tests with server api easily, too many changes required. |
|
It's going to get simpler when privilege separation patch has landet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to test server-api with ipa-run-tests. It is useful because
internal error tracebacks are printed to test output and it is handy to
use it with python -bb option to check BytesWarnings