Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Bytes and deprecation warnings #458

Closed
wants to merge 5 commits into from
Closed

Enable Bytes and deprecation warnings #458

wants to merge 5 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Feb 10, 2017 •
edited by MartinBasti

  • Enable bytes and deprecation warnings
  • Fix a couple of bytes and deprecation warnings

https://fedorahosted.org/freeipa/ticket/6631

@tiran
Enable additional warnings (BytesWarning, DeprecationWarning)
5b17ca0 
Closes: https://fedorahosted.org/freeipa/ticket/6631
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
cryptography has deprecated serial in favor of serial_number
64704c3 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Stable _is_null check
dc42e96 
Avoid comparison of bytes with int in _is_null() check. b'' == 0
triggers a BytesWarning.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
test_StrEnum: use int as bad type
a071eb4 
bytes triggers a BytesWarning error.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Ditch version_info and use version number from ipapython.version
540d74a 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran changed the title Bytes deprecation warnings Enable Bytes and deprecation warnings Feb 10, 2017
@abbra
Copy link
Contributor

abbra commented Feb 10, 2017

Thanks. LGTM.

MartinBasti
MartinBasti reviewed Feb 10, 2017
View reviewed changes
Copy link
Contributor

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Feb 10, 2017
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a33b25dea988aa34844869a8adc57d5cd396d3aa
https://fedorahosted.org/freeipa/changeset/3d9bec2e879d60e6bb7b2602084d3314765a6283
https://fedorahosted.org/freeipa/changeset/e6129a76e7093b8f9f7717e5f63ed06f9e9ef30a
https://fedorahosted.org/freeipa/changeset/4965735382425356ece27e7827e2a91bc2ab2055
https://fedorahosted.org/freeipa/changeset/8d3bea8accb9814b3a973f4a606110fee78baf72

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Feb 10, 2017
@stlaz stlaz mentioned this pull request Feb 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBasti MartinBasti MartinBasti left review comments

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @abbra @MartinBasti