Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues found by new pylint 2.5.0 #4605

Closed
wants to merge 1 commit into from
Closed

Address issues found by new pylint 2.5.0 #4605

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 28, 2020

  • fix multiple exception-escape
  • fix function signatures of DsInstance start/stop/restart
  • silence f-string-without-interpolation
  • silence import error in Azure script
  • silence too-many-function-args

Fixes: https://pagure.io/freeipa/issue/8297
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran added needs review Pull Request is waiting for a review ipa-4-6 Mark for backport to ipa 4.6 ipa-4-8 Mark for backport to ipa 4.8 labels Apr 28, 2020
stanislavlevin
stanislavlevin reviewed Apr 28, 2020
View reviewed changes
pylintrc Outdated Show resolved Hide resolved
@stanislavlevin
Copy link
Contributor

@tiran, please, see inline comments.

@tiran
Address issues found by new pylint 2.5.0
6ba8777 
* fix multiple exception-escape
* fix function signatures of DsInstance start/stop/restart
* silence f-string-without-interpolation
* fix too-many-function-args in host plugin

Fixes: https://pagure.io/freeipa/issue/8297
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@stanislavlevin
Copy link
Contributor

stanislavlevin commented Apr 29, 2020 •
edited

I've verified this PR locally using Pylint 2.5.0 (F31+ipa-master).
There are no warnings/errors.

@stanislavlevin
Copy link
Contributor

ACK.

@stanislavlevin stanislavlevin added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Apr 30, 2020
@fcami fcami added the pushed Pull Request has already been pushed label Apr 30, 2020
@fcami
Copy link
Contributor

fcami commented Apr 30, 2020

master:

  • 9941c9e Address issues found by new pylint 2.5.0

@fcami fcami closed this Apr 30, 2020
@fcami
Copy link
Contributor

fcami commented Apr 30, 2020

@tiran both automatic backports failed. Could you please create the backport PRs manually?

This was referenced Apr 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislavlevin stanislavlevin stanislavlevin left review comments

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-6 Mark for backport to ipa 4.6 ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @stanislavlevin @fcami