Bump required python-cryptography version #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
changed the title
|
NACK, you didn't update the comments. |
stlaz
force-pushed
the
cryptography_bump
branch
from
ce3e60c
to
2de0565
Compare
HonzaCholasta
added
ack
|
Fixed upstream |
|
|
stlaz
force-pushed
the
cryptography_bump
branch
from
2de0565
to
eaed208
Compare
|
Didn't realize we need that as well now, patch is in this PR. |
stlaz
removed
ack
|
@stlaz can you please link https://fedorahosted.org/freeipa/ticket/6631 to the fixup commit? |
When bumping version of python-cryptography in freeipa.spec.in, ipasetup.py.in was forgotten about. https://fedorahosted.org/freeipa/ticket/6631
stlaz
force-pushed
the
cryptography_bump
branch
from
eaed208
to
0f2477c
Compare
|
@martbab Sure, done. |
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started using
Certificate.serial_numberinstead of.serialfrom python-cryptography (3d9bec2), bump the required version to the one where the above mentioned transition happened (pyca/cryptography@e295f3a).