WebUI: Size limit warning on details pages fixed #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to suppress the warning and use sensible size limit. I.e. the entity select doesn't need to show all entries. I'm afraid that it might have negative performance impact. |
pvoborni
requested changes
Mar 7, 2017
pvoborni
reviewed
Mar 17, 2017
install/ui/src/freeipa/rpc.js
Outdated
| @@ -219,6 +225,7 @@ rpc.command = function(spec) { | |||
|
|
|||
| for (var i=0,l=msgs.length; i<l; i++) { | |||
| var msg = lang.clone(msgs[i]); | |||
| if (that.suppress_warnings.indexOf(msg.code) > -1) break; | |||
There was a problem hiding this comment.
Shouldn't it be continue instead of break? So that it will process also other possible msgs which you don't want to suppress.
added 2 commits
March 23, 2017 16:23
Each command can have specified an array of warning codes which will be suppressed and won't be shown. For specifying this it is necessary to set command property 'supressed_warnings: [codes_of_warning]' Part of: https://pagure.io/freeipa/issue/6618
This widget is used on details pages and dialogs. When the size limit is set to lower number the warning about truncation was shown every time the details page was open. Now, with support for suppressing warning messages from server according to its code, we are able to disable warning with 13017 code (truncation warning) https://pagure.io/freeipa/issue/6618
pvoborni
approved these changes
Mar 24, 2017
|
Code looks good and works fine, ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity select fields accepted globally set size limit and in situations when
there were more entries than global size limit allows then the "Truncated" warning
shows up. Also only subset of items was shown.
All entity select widgets now uses find methods with sizelimit set to 0
which says get all entries.
This setting is configurable using search_all_entries attribute.
https://fedorahosted.org/freeipa/ticket/6618