Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipatests: fix the disable_dnssec_validation method #4800

Closed
wants to merge 1 commit into from

Conversation

flo-renaud
Copy link
Contributor

Bind configuration now includes 2 snippet config files, in
/etc/named/ipa-ext.conf and /etc/named/ipa-options-ext.conf

When a test needs to disable dnssec-validation, it needs to edit
the snippet ipa-options-ext.conf instead of /etc/named.conf.

This commit fixes the method tasks.disable_dnssec_validation so that it
correctly updates the snippet.

Fixes: https://pagure.io/freeipa/issue/8364

@flo-renaud flo-renaud added the ipa-4-8 Mark for backport to ipa 4.8 label Jun 10, 2020
@flo-renaud
Copy link
Contributor Author

  • test_smb issues are known failures: 8184 and 8344
  • test_sssd issue is a known failure: 8294
  • test_trust issue is a known failure: 8365
    The tests show that ipa trust-add command is now working, the failures happen after this step.

@tiran tiran added the ack Pull Request approved, can be merged label Jun 10, 2020
@flo-renaud flo-renaud force-pushed the t8364 branch 2 times, most recently from 384a67b to b8ad621 Compare June 10, 2020 15:51
@abbra
Copy link
Contributor

abbra commented Jun 10, 2020

Linting issues:

2020-06-10T14:27:22.8729694Z pylint
2020-06-10T14:27:22.8731171Z ------
2020-06-10T14:27:30.4404108Z �[7;33m************* Module ipatests.pytest_ipa.integration.tasks�[0m
2020-06-10T14:27:30.4409849Z ipatests/pytest_ipa/integration/tasks.py:537: [E1101(�[1;31mno-member�[0m), disable_dnssec_validation] �[1;31mInstance of 'BasePathNamespace' has no 'NAMED_CUSTOM_OPTIONS_CONFIG' member�[0m)
2020-06-10T14:27:30.4411884Z ipatests/pytest_ipa/integration/tasks.py:538: [E1101(�[1;31mno-member�[0m), disable_dnssec_validation] �[1;31mInstance of 'BasePathNamespace' has no 'NAMED_CUSTOM_OPTIONS_CONFIG' member�[0m)
2020-06-10T14:27:30.4413024Z ipatests/pytest_ipa/integration/tasks.py:541: [E1101(�[1;31mno-member�[0m), disable_dnssec_validation] �[1;31mInstance of 'BasePathNamespace' has no 'NAMED_CUSTOM_OPTIONS_CONFIG' member�[0m)
2020-06-10T14:27:30.4413552Z 
2

@abbra abbra removed the ack Pull Request approved, can be merged label Jun 10, 2020
@abbra
Copy link
Contributor

abbra commented Jun 10, 2020

Removed ack due to linting issues.

Bind configuration now includes 2 snippet config files, in
/etc/named/ipa-ext.conf and /etc/named/ipa-options-ext.conf

When a test needs to disable dnssec-validation, it needs to edit
the snippet ipa-options-ext.conf instead of /etc/named.conf.

This commit fixes the method tasks.disable_dnssec_validation so that it
correctly updates the snippet.

Fixes: https://pagure.io/freeipa/issue/8364
@flo-renaud
Copy link
Contributor Author

@abbra
the lint issues have been fixed

@abbra abbra added the ack Pull Request approved, can be merged label Jun 11, 2020
@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Jun 11, 2020
@flo-renaud
Copy link
Contributor Author

master:

  • 1487665 ipatests: fix the disable_dnssec_validation method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
3 participants