New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipatests: fix the disable_dnssec_validation method #4800
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
approved these changes
Jun 10, 2020
tiran
approved these changes
Jun 10, 2020
flo-renaud
force-pushed
the
t8364
branch
2 times, most recently
from
June 10, 2020 15:51
384a67b
to
b8ad621
Compare
Linting issues:
|
Removed ack due to linting issues. |
Bind configuration now includes 2 snippet config files, in /etc/named/ipa-ext.conf and /etc/named/ipa-options-ext.conf When a test needs to disable dnssec-validation, it needs to edit the snippet ipa-options-ext.conf instead of /etc/named.conf. This commit fixes the method tasks.disable_dnssec_validation so that it correctly updates the snippet. Fixes: https://pagure.io/freeipa/issue/8364
@abbra |
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind configuration now includes 2 snippet config files, in
/etc/named/ipa-ext.conf and /etc/named/ipa-options-ext.conf
When a test needs to disable dnssec-validation, it needs to edit
the snippet ipa-options-ext.conf instead of /etc/named.conf.
This commit fixes the method tasks.disable_dnssec_validation so that it
correctly updates the snippet.
Fixes: https://pagure.io/freeipa/issue/8364