FIPS: Remove pkispawn cruft #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tiran
reviewed
Feb 20, 2017
ipaserver/install/dogtaginstance.py
Outdated
| @@ -171,6 +167,15 @@ def spawn_instance(self, cfg_file, nolog_list=()): | |||
| except ipautil.CalledProcessError as e: | |||
| self.handle_setup_error(e) | |||
|
|
|||
| def _clean_pkispawn_files(self): | |||
| if self.tmp_agent_db is None: | |||
There was a problem hiding this comment.
You are skipping the removal of /root/.dogtag/pki-tomcat/{subsystem}, too.
There was a problem hiding this comment.
Right, it was my impression that this one would not exist if pkispawnwas not run, I can just remove this check and run removal of both trees.
tiran
reviewed
Feb 20, 2017
|
Hm, originally had this over the nsslib removal patchset but the rebase was not as successful as I thought, will fix the issues. |
|
Or you could always clean up By the way do you clean up |
The ra_db argument to CAInstance init is a constant so it can be removed. This constant corresponds to the default CertDB directory and since CertDB now passes passwords to its inner NSSDatabase instance we do need to care about having our own run_certutil() method. https://fedorahosted.org/freeipa/ticket/5695
|
Always tend to forget about the upgrade part, will do, thanks 👍 |
|
pylint needs some attention, too. |
stlaz
force-pushed
the
remove_pkispawn_cruft
branch
from
fb06ea7
to
5796207
Compare
|
All should be fixed now. |
|
Works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkispawnleaves some ugly files after its successful run. This patch:a) makes sure the files are removed (say no to
__del__inDogtagInstance)b) prevents special requirements for DM password in FIPS as this was for some reason used to create an NSS database for
pkispawn