Fix error in ca_cert_files validator #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientInstall expects a single ca_cert_file as a string but the framework gives it a list. https://fedorahosted.org/freeipa/ticket/6694
tiran
reviewed
Feb 21, 2017
| @@ -3555,6 +3555,10 @@ class ClientInstall(ClientInstallInterface, | |||
|
|
|||
| @ca_cert_files.validator | |||
| def ca_cert_files(self, value): | |||
| if not isinstance(value, list): | |||
There was a problem hiding this comment.
Does it makes sense to check for len(value) == 1, too?
if not isinstance(value, list) or len(value) != 1:
raise ValueError("Expected list of length 1, got {!r}".format(value))
There was a problem hiding this comment.
This check is performed in the option parser itself.
|
tentative ack, see comment |
tiran
approved these changes
Feb 21, 2017
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientInstall expects a single ca_cert_file as a string but the
framework gives it a list.
https://fedorahosted.org/freeipa/ticket/6694