Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributors.txt #493

Closed
wants to merge 1 commit into from
Closed

Conversation

mkosek
Copy link
Member

@mkosek mkosek commented Feb 21, 2017

Update mailmap with the new mistyped authors and generate a new
Contributors list.

Update mailmap with the new mistyped authors and generate a new
Contributors list.
@@ -18,13 +18,13 @@ Developers:
Thierry Bordaz
Sumit Bose
François Cami
Petr Čech
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the lexicographic ordering isn't quite right, Č should come after C

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When sorting, I use English collator:

collator = icu.Collator.createInstance(icu.Locale('en_US.UTF-8'))
authors.sort(cmp=collator.compare, key=lambda x: x.split()[-1].lower())

I could change it to Czech collator, but then for example surnames beginning with "Ch" are sorted after "H", which would confuse English speakers.

So I would rather stick with current working version (already applied to names like Špaček) to make the sorting clear for wide population.

@stlaz
Copy link
Contributor

stlaz commented Feb 23, 2017

I don't give two poops and a popsicle about the order of names in the Contributors.txt file. ACK.

@stlaz stlaz added the ack Pull Request approved, can be merged label Feb 23, 2017
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Feb 23, 2017
@MartinBasti
Copy link
Contributor

@MartinBasti
Copy link
Contributor

If script for generating contributors file was published it may be documented in releasing page and it may be part of each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants