Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipa-server-upgrade #495

Closed
wants to merge 1 commit into from
Closed

Fix ipa-server-upgrade #495

wants to merge 1 commit into from

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Feb 22, 2017

I was to eager to ACK #471.

Running ipa-server-upgrade would fail to stop ipa_memcached if
it's already uninstalled.

@tiran
Copy link
Member

tiran commented Feb 22, 2017

Looks totally reasonable.

I checked, SimpleServiceInstance('ipa_memcached') does not raise an exception if systemd has no service file for IPA memcached at all.

@tiran tiran self-requested a review February 22, 2017 11:51
@tiran tiran added the ack Pull Request approved, can be merged label Feb 22, 2017
@MartinBasti
Copy link
Contributor

Does this belong to any ticket which caused this regression?

@HonzaCholasta
Copy link
Contributor

Running ipa-server-upgrade would fail to stop ipa_memcached if
it's already uninstalled.

https://fedorahosted.org/freeipa/ticket/5959
@stlaz
Copy link
Contributor Author

stlaz commented Feb 23, 2017

I see where this is going, added the ticket to the commit message.

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Feb 23, 2017
@MartinBasti
Copy link
Contributor

@stlaz stlaz deleted the fixup_fixup branch September 11, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants