Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newer Certificate.serial_number in krainstance.py #496

Closed
wants to merge 1 commit into from
Closed

Use newer Certificate.serial_number in krainstance.py #496

wants to merge 1 commit into from

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Feb 23, 2017 •
edited by MartinBasti

This bit was missed in #458

@flo-renaud flo-renaud self-requested a review February 23, 2017 08:13
@flo-renaud
Copy link
Contributor

Hi @stlaz ,

the warning /usr/lib/python2.7/site-packages/ipaserver/install/krainstance.py:316: DeprecationWarning: Certificate serial is deprecated, use serial_number instead. is not present anymore.
ACK.

@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Feb 23, 2017
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/8c2cd66269d7be976ae7fc990343ed8e9b5282a3

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Feb 23, 2017
@stlaz stlaz deleted the kra_serial branch September 11, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-renaud flo-renaud Awaiting requested review from flo-renaud

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@stlaz @flo-renaud @MartinBasti