[WIP] Update testcase for cert plugin #503
Conversation
Fixes https://fedorahosted.org/freeipa/ticket/6275 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
There was a problem hiding this comment.
I still miss tests for cert-find and following attributes:
- Issuing CA
- Subject
- Issuer
- Serial number
- Serial number (hex)
- Status
- Revoked
Is possible to implement a Tracker for certificates and create a testing certificate and compare all expected and received values?
| @@ -191,10 +192,10 @@ def test_0005_cert_uris(self): | |||
|
|
|||
| See https://fedorahosted.org/freeipa/ticket/5881 | |||
| """ | |||
| result = api.Command.cert_show(sn, out=unicode(self.certfile)) | |||
| api.Command['cert_show'](sn, out=unicode(self.certfile)) | |||
There was a problem hiding this comment.
result is unused and wanted to make api call uniform with other calls.
| Show status of certificate using request id and CA | ||
| """ | ||
| res = api.Command['cert_status'](request_id=1, | ||
| cacn=unicode('ipa'))['result'] |
There was a problem hiding this comment.
please use u'ipa' instead of unicode(ipa)
| """ | ||
| Show status of certificate using request id | ||
| """ | ||
| res = api.Command['cert_status'](request_id=1)['result'] |
There was a problem hiding this comment.
I'm not sure, can we always assume that request with id=1 is there?
There was a problem hiding this comment.
We will surely have request_id=1 which is used for IPA CA certificate. That's why I used request id 1. We can change this if this is not the case.
| fp = open(self.pwname, "w") | ||
| fp.write("\n") | ||
| fp.close() | ||
| with open(self.pwname, "w") as fp: |
There was a problem hiding this comment.
This should be in separate commit
| @@ -122,9 +124,8 @@ def generateCSR(self, subject): | |||
| "-f", self.pwname, | |||
| "-a", | |||
| ]) | |||
| fp = open(self.reqfile, "r") | |||
| data = fp.read() | |||
| fp.close() | |||
There was a problem hiding this comment.
This refactoring should be in separate commit
| @@ -50,6 +50,7 @@ | |||
| _EXP_CRL_URI = ''.join(['http://ipa-ca.', _DOMAIN, '/ipa/crl/MasterCRL.bin']) | |||
| _EXP_OCSP_URI = ''.join(['http://ipa-ca.', _DOMAIN, '/ca/ocsp']) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This PEP8fix should be in separate commit
There was a problem hiding this comment.
OK. I will keep this in mind for future.
| @@ -97,15 +100,14 @@ def run_certutil(self, args, stdin=None): | |||
| return ipautil.run(new_args, stdin) | |||
|
|
|||
| def setup(self): | |||
| self.reqdir = tempfile.mkdtemp(prefix = "tmp-") | |||
| self.reqdir = tempfile.mkdtemp(prefix="tmp-") | |||
There was a problem hiding this comment.
Pep8 fix should be in separate commit
|
I left some inline comments, this improves the test but it still misses several features to be tested. |
|
@MartinBasti I am working on other improvements and will update this PR accordingly.
|
|
@Akasurde what is your opinion about creating a Tracker class for certificate? |
|
@MartinBasti Will implement tracker class in different PR. |
|
Closing for inactivity. If this PR is still relevant, please re-open it. |
Fixes https://fedorahosted.org/freeipa/ticket/6275
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com