New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHA256 fingerprints #504
Conversation
|
As discussed about hundred times before, do not touch |
|
Do not touch |
f26f6d1
to
690ff81
Compare
|
I've dropped the commit that modified the deprecated file. |
690ff81
to
6664a94
Compare
|
I wanted to test this but nothing is currently shown for either SHA-1 or SHA256 fingerprints in the WebUI so you can either fix it or we'll wait till @pvomacka has that done. |
|
@stlaz , @tomaskrizek I will fix that today. |
|
@tomaskrizek actually you did almost all necessary steps. Just please check inline comments where is described one another change. And in general you do not have to add anything into json files as they are present just because of historical reasons and will be removed soon. |
|
@tomaskrizek so, inline comment is not possible to the line where file was not changed. So, please remove line 1979: delete command.options.all; . That should be enough to display fingerprints correctly. Thank you |
6664a94
to
3ee0bda
Compare
|
@pvomacka Thanks! Should be fixed now. |
3ee0bda
to
b61cfc0
Compare
|
Please transform |
|
I think this is a translation issue that will resolve itself once we generate new translation files. Is that correct, @MartinBasti ? When using |
|
Hm, apparently I had old |
|
master:
|
As discussed on the devel list, adding SHA256 fingerprints for certs and keeping SHA1 as well.