Don't allow both a zone name and --name-from-ip to be provided #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--name-from-ip will generate a zone name so there is no point in the user providing one. If one is provided and doesn't match the generated name then a validation exception is raised. https://pagure.io/freeipa/issue/8446 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
If a zone name is provided then name-from-ip makes little sense, don't allow it. https://pagure.io/freeipa/issue/8446 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten
force-pushed
the
issue_8446
branch
from
f17ba0d
to
cdbf53d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM. ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allow both a zone name and --name-from-ip to be provided
--name-from-ip will generate a zone name so there is no point in
the user providing one. If one is provided and doesn't match the
generated name then a validation exception is raised.
https://pagure.io/freeipa/issue/8446