Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing negative tests for deprecated params #51

Closed
wants to merge 1 commit into from
Closed

Fix failing negative tests for deprecated params #51

wants to merge 1 commit into from

Conversation

martbab
Copy link
Contributor

@martbab martbab commented Sep 2, 2016 •
edited

Fixes https://fedorahosted.org/freeipa/ticket/6190

There is one last failing test. To fix it properly we will have to rework
Parameter.__init__ method, see https://fedorahosted.org/freeipa/ticket/6292

@mirielka mirielka self-assigned this Sep 2, 2016
@mirielka mirielka added the ack Pull Request approved, can be merged label Sep 2, 2016
@martbab
Copy link
Contributor Author

martbab commented Sep 5, 2016

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/82e754e9c5e46317c7c060d9bc9c00ee259101a1
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/4d4ea09a82cf9234a0f3cec43fd1551acae5780c

@martbab martbab added the pushed Pull Request has already been pushed label Sep 5, 2016
@martbab martbab closed this Sep 5, 2016
@martbab martbab deleted the t_6190 branch September 8, 2016 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mirielka mirielka

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@martbab @mirielka