Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault: port key wrapping to python-cryptography #510

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Feb 25, 2017

@tiran
Copy link
Member Author

tiran commented Feb 27, 2017

@simo5 Do I remember correctly that PKCS1v1.5 side channel attacks applies only to unpadding and not to padding?

@tiran
Copy link
Member Author

tiran commented Feb 27, 2017

I can answer the question myself. The side channel attack on RSAEP PKCS1 v1.5 is a chosen-ciphertext attack Bleichenbacher attack. It applies to unpadding and RSA decryption, because its only a danger to the side that owns the private key. Therefore

@stlaz stlaz self-assigned this Mar 1, 2017
@stlaz
Copy link
Contributor

stlaz commented Mar 2, 2017

Tested this and gone through the code, both was fine. ACK.

@stlaz stlaz added the ack Pull Request approved, can be merged label Mar 2, 2017
@MartinBasti
Copy link
Contributor

master:

  • ed7a03a Vault: port key wrapping to python-cryptography

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Mar 2, 2017
@MartinBasti MartinBasti closed this Mar 2, 2017
@tiran tiran deleted the pyca_vault branch March 14, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants