Re-add ipapython.config.config for backwards compatibilty #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPAConfig, config and init_config were removed in rev 7b966e8. Ipsilon uses ipapython.config to get realm, domain and server of an enrolled host. Re-add a simplified version that reads settings from api.env. init_config() does not perform DNS discovery. Depends on PR freeipa#492 to get meaningful defaults. https://fedorahosted.org/freeipa/ticket/6707 Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
IIRC we agreed that there should be warning that this is deprecated and |
|
I can add a deprecation warning after we have agreed upon a new API. What's the official way to get the values w/o requiring credentials? |
|
Could we please revert to the original |
|
OK, I'm closing this PR then. @HonzaCholasta, please open another PR and revert 7b966e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPAConfig, config and init_config were removed in rev 7b966e8. Ipsilon uses
ipapython.config to get realm, domain and server of an enrolled host. Re-add
a simplified version that reads settings from api.env. init_config() does
not perform DNS discovery.
Depends on PR #492 to get meaningful defaults.
https://fedorahosted.org/freeipa/ticket/6707
Signed-off-by: Christian Heimes cheimes@redhat.com