Removed incorrect check for returncode #52
Conversation
| @@ -1190,7 +1190,7 @@ def run_server_del(host, server_to_delete, force=False, | |||
| def assert_error(result, stderr_text, returncode=None): | |||
| "Assert that `result` command failed and its stderr contains `stderr_text`" | |||
| assert stderr_text in result.stderr_text, result.stderr_text | |||
| if returncode: | |||
| if returncode is not None: | |||
There was a problem hiding this comment.
Why this change is needed?
|
ACK: Removed incorrect check for returncode |
|
The commit message was updated |
MartinBasti
added
ack
|
I went through commit messages again and I changed my mind, NACK: commit: Removed incorrect check for returncode This commit contains incorrect ticket, issue has not been fixed by this commit commit: Several fixes in replica_promotion tests This does not have ticket, is okay to push it just to master? All commits have different tickets, so I have to manually split hashes and put it to proper tickets. Leave it as is for this PR to avoid mess, but in future create one PR for one ticket |
The server installation in most cases returns response code 0 no matter what happens except for really severe errors. In this case when we try to uninstall the middle replica of a line topology, it fails, notifies us that we should use '--ignore-topology-disconnect', but returns 0 https://fedorahosted.org/freeipa/ticket/6300
|
@mbasti-rh,
|
|
Ad 2. yes |
In test_one_command_installation the ipa-replica-install was missing '--server' and '-U' options which resulted in false negative result. In test_client_enrollment_by_unprivileged_user '--server' option was messing. test_replica_promotion_after_adding_to_admin_group lacked '-U' option. It leaded to 3 failed cases. https://fedorahosted.org/freeipa/ticket/6301
|
Done |
|
Removed incorrect check for returncode Fixed upstream |
|
Several fixes in replica_promotion tests Fixed upstream |
|
Changed addressing to the client hosts to be replicas Fixed upstream |
|
Xfailed the tests due to a known bug with replica preparation Fixed upstream |
The server installation in most cases returns response code 0 no matter what
happens except for really severe errors. In this case when we try to uninstall
the middle replica of a line topology, it fails, notifies us that we should use
'--ignore-topology-disconnect', but returns 0
https://fedorahosted.org/freeipa/ticket/3230