Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NSPRError exception from platform tasks #524

Closed
wants to merge 1 commit into from
Closed

Remove NSPRError exception from platform tasks #524

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 1, 2017 •
edited by MartinBasti

ipalib.x509 no longer raises NSPRError. PyCA cryptography raises
ValueError for invalid certs.

https://fedorahosted.org/freeipa/ticket/5695

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran requested a review from stlaz March 1, 2017 10:21
@stlaz
Copy link
Contributor

stlaz commented Mar 1, 2017 •
edited

Indeed, NSPRError is NSS-specific. However, isn't CertificateFormatError raised in case python-cryptography fails to validate the cert format?

@tiran
Copy link
Member Author

tiran commented Mar 1, 2017

CertificateFormatError is a custom exception that is only raised by ipalib.x509.CertificateFormatError. The rest of the ipalib.x509 propagates the ValueError from cryptography.

@stlaz stlaz self-assigned this Mar 1, 2017
@tiran
Remove NSPRError exception from platform tasks
7ed05a0 
ipalib.x509 no longer raises NSPRError. PyCA cryptography raises
ValueError for invalid certs.

https://fedorahosted.org/freeipa/ticket/5695

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@stlaz
Copy link
Contributor

stlaz commented Mar 1, 2017

The patch seems ok now. ACK.

@stlaz stlaz added the ack Pull Request approved, can be merged label Mar 1, 2017
@MartinBasti
Copy link
Contributor

master:

  • 88fd936 Remove NSPRError exception from platform tasks

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Mar 1, 2017
@MartinBasti MartinBasti closed this Mar 1, 2017
@tiran tiran deleted the ipaplatform_nss branch March 14, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@stlaz stlaz

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @stlaz @MartinBasti