Fix cookie with Max-Age processing

[stlaz]

When cookie has Max-Age set it tries to get expiration by adding
to a timestamp. Without this patch the timestamp would be set to
None and thus the addition of timestamp + max_age fails

https://pagure.io/freeipa/issue/6718

[tiran]

UTC

[tiran]

datetime.datetime.utcnow()

Our cookie library uses UTC but now() returns a naive localized time stamp.

[stlaz]

Thanks, fixed.

[simo5]

Do we really care for calculating the expiration time ?
Should we just set timestamp to 0 or even remove the whole thing ?

[stlaz]

If I read the code well, in a well-set-up cookie, during store_session_cookie() when Cookie.get_named_cookie_from_string() is called, the expiration gets normalized which basically means removing the Max-Age attribute and replacing it with the Expires attribute in the cookie string (see Cookie.normalize_expiration() and Cookie.__str__()). When later retrieving the cookie, it should not have the Max-Age attribute anymore but only Expires. Therefore we need to calculate it or change the way normalize_expiration() behaves.

[simo5]

Ok, sorry for some reason I thought this was on the server side, where we do not care what the cookie looks like, but on the client side we indeed care.

[apophys]

Hi, can this PR get little more attention? The issue seems to be a cause for a lot of failures in our integration tests. (I'm not 100% sure though)

[simo5]

LGTM, please merge

Change applied

[HonzaCholasta]

master:

• 24eeb4d Fix cookie with Max-Age processing