test_csrgen: adjusted comparison test scripts for CSRGenerator #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
approved these changes
Mar 3, 2017
apophys
suggested changes
Mar 3, 2017
| openssl req -new -config "$CONFIG" -out "$CSR" -key $1 | ||
| rm "$CONFIG" | ||
| openssl req -new -config "$CONFIG" -out "$CSR" -key "$KEYFILE" "$@" | ||
| rm "$CONFIG" |
There was a problem hiding this comment.
The missing newline at the EOF breaks test_CSRGenerator.test_caIPAserviceCert_OpenSSL test case.
Commit ada91c2 introduced changes in "csrgen/templates/openssl_base.tmpl" which broke the following 2 tests: test_CSRGenerator.test_userCert_OpenSSL test_CSRGenerator.test_caIPAserviceCert_OpenSSL The tests use files caIPAserviceCert_openssl.sh and userCert_openssl.sh as expected scripts in order to compare scripts generated by CSRGenerator. E.g. as other parameter was introduced we are now not checking with "if [[ $# -ne 2 ]]" but rather with if "[[ $# -lt 2 ]]". https://pagure.io/freeipa/issue/6724
apophys
approved these changes
Mar 3, 2017
|
Thanks for catching this, sorry about the breakage. The change looks good to me. |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ada91c2 introduced changes in "csrgen/templates/openssl_base.tmpl"
which broke the following 2 tests:
The tests use files caIPAserviceCert_openssl.sh and userCert_openssl.sh$# -ne 2 ]]" but rather with if "[[ $ # -lt 2 ]]".
as expected scripts in order to compare scripts generated by CSRGenerator.
E.g. as other parameter was introduced we are now not checking with
"if [[
https://pagure.io/freeipa/issue/6724