Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define errors_by_code in ipalib.errors #539

Conversation

frasertweedale
Copy link
Contributor

The errors_by_code mapping will soon be used in more places, as part
of the Dogtag GSS-API authentication work. Move its definition to
ipalib.errors.

Part of: https://pagure.io/freeipa/issue/5011

The errors_by_code mapping will soon be used in more places, as part
of the Dogtag GSS-API authentication work.  Move its definition to
ipalib.errors.

Part of: https://pagure.io/freeipa/issue/5011
@HonzaCholasta
Copy link
Contributor

The codes are only relevant for XML-RPC. Why do you need them?

@frasertweedale
Copy link
Contributor Author

frasertweedale commented Mar 6, 2017

@HonzaCholasta when Dogtag execute the existing cert-request validation logic (which will be extracted to a new function), if an exception gets raised Dogtag returns it in the response, and IPA reconstructs it, so that there is no change to the user experience.

Pickling is an alternative.

@HonzaCholasta
Copy link
Contributor

Seems like an overkill for the ~2 types of errors which the code uses. Anyway, I would rather wait before making any kind of decision based on cert-request code until after it is refactored to be less insane (https://pagure.io/freeipa/issue/6531).

@frasertweedale
Copy link
Contributor Author

Righto. I'll withdraw this PR for now and it will make a comeback closer to landing the gssapi work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants