Add options to allow ticket caching #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
cachetickets
branch
2 times, most recently
from
513c118
to
4c13d33
Compare
|
LGTM. Here I'd also like to bump gssproxy and krb5 dependencies in the spec file. We need to ensure gssproxy is actually updated. |
|
Yes, I think we should add a new PR later once we release gssproxy 0.7 |
|
Bump |
|
@simo5 please resolve the merge conflict |
simo5
force-pushed
the
cachetickets
branch
2 times, most recently
from
9a89d1d
to
d2c6121
Compare
|
@MartinBasti can we push this ? It makes a big difference in framework performance and load on the KDC |
This new option (planned to land in gssproxy 0.7) we cache the ldap ticket properly and avoid a ticket lookup to the KDC on each and every ldap connection. (Also requires krb5 libs 1.15.1 to benefit from caching). Ticket: https://pagure.io/freeipa/issue/6771 Signed-off-by: Simo Sorce <simo@redhat.com>
|
I think that we have all dependencies in spec already so I do not see a reason not to. |
martbab
added
ack
|
master:
|
|
@martbab, the ticket says 4.5.1, but this was not pushed to ipa-4-5. |
|
ipa-4-5:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new option (planned to land in gssproxy 0.7) we cache the ldap
ticket properly and avoid a ticket lookup to the KDC on each and every
ldap connection. (Also requires krb5 libs 1.15.1 to benefit from caching).
NOTE: It is safe to apply this to master, if gssproxy does not support this option it simply is ignored.