New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: certmap match #549
WebUI: certmap match #549
Conversation
1b4f8dc
to
57778d5
Compare
|
Rebased. PR #400 already merged. |
57778d5
to
08ce788
Compare
|
In last sync I changed string of clear button title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, the leading space. Would be good to have some lint rule for that. It feels weird to nack this because of it.
Otherwise looks good and works find - tested on vm provided by @pvomacka
install/ui/src/freeipa/field.js
Outdated
| * | ||
| * @type {Number|null} | ||
| */ | ||
| object_index: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect leading space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
When field on details facet has set 'autoload_value' to false, then it won't be loaded using that.load method of details facet. That means that field might stay unchanged even that loading of data was performed. Part of: https://pagure.io/freeipa/issue/6601
…ects In case that API call returns array of objects which contains data, using 'object_index' attribute in adapter specification we can set which object should be used. It is possible to choose only one object specified by its index in array. Part of: https://pagure.io/freeipa/issue/6601
Result of certmap_match command is in the following format:
[{domain: 'domain1', uid:[uid11,uid12,uid13]}, {domain: 'domain2',
uid:[uid21, uid22, uid23},...]
For correct displaying in table we need to reformat it to the following:
[{domain: 'domain1', uid: 'uid11'}, {domain: 'domain1', uid: 'uid12'},...
This can be done using this Adapter.
Part of: https://pagure.io/freeipa/issue/6601
Add module which can show users which are mapped to the provided certificate. Additionaly, the certificate is parsed and parsed information are also displayed. https://pagure.io/freeipa/issue/6601
08ce788
to
34ee173
Compare
|
@pvoborni Yes, we should make a lint rule for leading spaces. |
|
But let's wait with pushing for travis, to be sure. |
WebUI: add support for certmap match command.
PR contains also certmap rule patches from pullrequest #400 (I will rebase once #400 will be merged) because they are necessary. It also requires PRs #398 and #516.
https://pagure.io/freeipa/issue/6601