Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: certmap match #549

Closed
wants to merge 4 commits into from
Closed

Conversation

pvomacka
Copy link

@pvomacka pvomacka commented Mar 7, 2017

WebUI: add support for certmap match command.

PR contains also certmap rule patches from pullrequest #400 (I will rebase once #400 will be merged) because they are necessary. It also requires PRs #398 and #516.

https://pagure.io/freeipa/issue/6601

@pvomacka pvomacka changed the title T6601 certmap match WebUI: certmap match Mar 8, 2017
@pvomacka pvomacka force-pushed the t6601-certmap_match branch 2 times, most recently from 1b4f8dc to 57778d5 Compare March 8, 2017 09:16
@pvomacka
Copy link
Author

pvomacka commented Mar 8, 2017

Rebased. PR #400 already merged.

@pvomacka
Copy link
Author

pvomacka commented Mar 8, 2017

In last sync I changed string of clear button title.

Copy link
Member

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the leading space. Would be good to have some lint rule for that. It feels weird to nack this because of it.

Otherwise looks good and works find - tested on vm provided by @pvomacka

*
* @type {Number|null}
*/
object_index: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect leading space

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Pavel Vomacka added 4 commits March 8, 2017 15:51
When field on details facet has set 'autoload_value' to false, then it won't
be loaded using that.load method of details facet. That means that field
might stay unchanged even that loading of data was performed.

Part of: https://pagure.io/freeipa/issue/6601
…ects

In case that API call returns array of objects which contains data, using
'object_index' attribute in adapter specification we can set which object
should be used.

It is possible to choose only one object specified by its index in array.

Part of: https://pagure.io/freeipa/issue/6601
Result of certmap_match command is in the following format:
[{domain: 'domain1', uid:[uid11,uid12,uid13]}, {domain: 'domain2',
uid:[uid21, uid22, uid23},...]

For correct displaying in table we need to reformat it to the following:
[{domain: 'domain1', uid: 'uid11'}, {domain: 'domain1', uid: 'uid12'},...

This can be done using this Adapter.

Part of: https://pagure.io/freeipa/issue/6601
Add module which can show users which are mapped to the provided certificate.
Additionaly, the certificate is parsed and parsed information are
also displayed.

https://pagure.io/freeipa/issue/6601
@pvomacka
Copy link
Author

pvomacka commented Mar 8, 2017

@pvoborni Yes, we should make a lint rule for leading spaces.

@pvoborni pvoborni added the ack Pull Request approved, can be merged label Mar 8, 2017
@pvoborni
Copy link
Member

pvoborni commented Mar 8, 2017

But let's wait with pushing for travis, to be sure.

@ghost
Copy link

ghost commented Mar 8, 2017

master:

  • 6be32ed WebUI: Add possibility to turn of autoload when details.load is called
  • 1d6cc35 WebUI: Possibility to choose object when API call returns list of objects
  • 358caa7 WebUI: Add Adapter for certmap_match result table
  • 61cd437 WebUI: Add cermapmatch module

@ghost ghost added the pushed Pull Request has already been pushed label Mar 8, 2017
@ghost ghost closed this Mar 8, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants