Add check for removing last KRA server #553
Conversation
|
Hm, I forgot that KRA is the only IPA component that has a standalone uninstaller, this is therefore only a partial fix. |
|
@stlaz I wrote it to ticket |
|
@MartinBasti ah, sorry, I completely overlooked it. The current PR version implements your suggestion. |
|
Please create a separate commit for KRA Uninstall |
|
Split done. |
|
JFTR: KRA uninstall commit is here #556 |
There was a problem hiding this comment.
I got following error in webUI even I had only one server with both CA and KRA installed, this shouldn't happened
Warning: Only One CA/KRA Server Detected
It is strongly recommended to keep the KRA services installed on more than one server.
It is known bug that the warning is shown.
But in this case, there should be both warnings for CA and KRA, so it is broken by your patch, I got only KRA warning.
install/ui/src/freeipa/topology.js
Outdated
| var dialog = IPA.dialog({ | ||
| name: 'ca_warning', | ||
| title: '@i18n:objects.servers.ca_warning_title', | ||
| name: 'dogtag_warning', |
There was a problem hiding this comment.
I don't like to have just one common title
There was a problem hiding this comment.
Can you dynamically create that list? something like Warning: Only One {roles} Server Detected
|
Probably you we should fix this before we double number of alerts |
install/ui/src/freeipa/topology.js
Outdated
| if (ca_counter != 1 && kra_counter != 1) return; | ||
|
|
||
| var messages = []; | ||
| if (ca_counter == 1) |
There was a problem hiding this comment.
Please use '===' instead od '==', two equals might cause weird behavior.
And for better reading of code please use code block { } around commands after if statement. It will work if you have only one command after the condition, but in case that the command is not onliner it is better to have it in curly braces.
There was a problem hiding this comment.
== can't cause this, we know already that the types are equal as ca_counter is a local variable that is not assigned from any external source.
install/ui/src/freeipa/topology.js
Outdated
| $type: 'html', | ||
| html: text.get('@i18n:objects.servers.ca_warning_message') | ||
| }); | ||
| if (kra_counter == 1) |
There was a problem hiding this comment.
Same answer as above.
|
Fix for 6598 in #566 |
|
Reworked how the beg for a service replication worked. |
This patchset adds a check for removal of a last KRA server + adds a message about there only being one KRA to WebUI.